Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

File_Adapter: Create partial class placed in File_Adapter moved to File_Engine #135

Merged
merged 4 commits into from
Dec 14, 2022
Merged

File_Adapter: Create partial class placed in File_Adapter moved to File_Engine #135

merged 4 commits into from
Dec 14, 2022

Conversation

alelom
Copy link
Member

@alelom alelom commented May 24, 2022 •
edited
Loading

Issues addressed by this PR

Closes #134

Test files

https://burohappold.sharepoint.com/:w:/s/BHoM/EVWMrt6uTxpGubryxTlpmIABtA3ssfTVIhXkwViOIJZpxQ?e=btbI1e

Changelog

Additional comments

@alelom alelom self-assigned this May 24, 2022
@alelom alelom added the type:compliance Non-conforming to code guidelines label May 24, 2022
@FraserGreenroyd
Copy link
Contributor

@BHoMBot check serialisation

@bhombot-ci
Copy link

bhombot-ci bot commented Nov 22, 2022

@FraserGreenroyd to confirm, the following actions are now queued:

  • check serialisation

@alelom alelom added the type:bug Error or unexpected behaviour label Dec 14, 2022
@FraserGreenroyd
Copy link
Contributor

@BHoMBot check versioning

@bhombot-ci
Copy link

bhombot-ci bot commented Dec 14, 2022

@FraserGreenroyd to confirm, the following actions are now queued:

  • check versioning

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Dec 14, 2022

@FraserGreenroyd to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

There are 12 requests in the queue ahead of you.

@alelom alelom closed this Dec 14, 2022
@alelom alelom deleted the File_Adapter-#134-MoveCreateClass branch December 14, 2022 19:25
@FraserGreenroyd FraserGreenroyd restored the File_Adapter-#134-MoveCreateClass branch December 14, 2022 19:27
@FraserGreenroyd
Copy link
Contributor

@BHoMBot check compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Dec 14, 2022

@FraserGreenroyd to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Dec 14, 2022

@FraserGreenroyd to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

There are 3 requests in the queue ahead of you.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check versioning

@bhombot-ci
Copy link

bhombot-ci bot commented Dec 14, 2022

@FraserGreenroyd to confirm, the following actions are now queued:

  • check versioning

There are 5 requests in the queue ahead of you.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check core
@BHoMBot check null-handling
@BHoMBot check serialisation

@bhombot-ci
Copy link

bhombot-ci bot commented Dec 14, 2022

@FraserGreenroyd to confirm, the following actions are now queued:

  • check core
  • check null-handling
  • check serialisation

There are 3 requests in the queue ahead of you.

FraserGreenroyd
FraserGreenroyd approved these changes Dec 14, 2022
View reviewed changes
Copy link
Contributor

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has been reviewed in collaboration with @alelom for merge to beta.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Dec 14, 2022

@FraserGreenroyd to confirm, the following actions are now queued:

  • check ready-to-merge

There are 11 requests in the queue ahead of you.

@FraserGreenroyd FraserGreenroyd merged commit 530a57c into main Dec 14, 2022
@FraserGreenroyd FraserGreenroyd deleted the File_Adapter-#134-MoveCreateClass branch December 14, 2022 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FraserGreenroyd FraserGreenroyd FraserGreenroyd approved these changes

Assignees

@alelom alelom

Labels
type:bug Error or unexpected behaviour type:compliance Non-conforming to code guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

File_Adapter: Create partial class placed in File_Adapter to be moved to File_Engine
2 participants
@alelom @FraserGreenroyd